fix: tests with migrations_lock#9833
Merged
michalsn merged 1 commit intocodeigniter4:4.7from Dec 12, 2025
Merged
Conversation
neznaika0
approved these changes
Dec 11, 2025
Contributor
neznaika0
left a comment
There was a problem hiding this comment.
Does this mean that *_lock is not needed all the time? After each lock, the table must be deleted.
paulbalandan
approved these changes
Dec 12, 2025
Member
Author
|
@neznaika0 If we use In tests, however, we drop this table, as it is only needed for a few specific test cases. |
Member
Author
|
Thank you for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes tests migrations by ensuring the
migrations_locktable is always removed.No changelog entry, as this change is relevant only for tests.
Fixes #9832
Checklist: