fix: null as an array offset is deprecated, use an empty string instead#9848
Closed
ddevsr wants to merge 3 commits intocodeigniter4:4.7from
Closed
fix: null as an array offset is deprecated, use an empty string instead#9848ddevsr wants to merge 3 commits intocodeigniter4:4.7from
ddevsr wants to merge 3 commits intocodeigniter4:4.7from
Conversation
Member
|
While I agree with the approach taken in In Given that, I would limit the fix to the caching layer and simply change the $folderKey = $folder ?? '';
if (isset($this->cache['locateFile'][$file][$folderKey][$ext])) {
return $this->cache['locateFile'][$file][$folderKey][$ext];
}
$files = $this->locator->locateFile($file, $folder, $ext);
$this->cache['locateFile'][$file][$folderKey][$ext] = $files;
$this->cacheUpdated = true;
return $files; |
6a573b2 to
5ed5f12
Compare
Member
|
Hmm... I'm not sure what's happening with the Sanity Tests. Everything works fine locally, and the tests also pass on GitHub Actions: https://github.com/michalsn/CodeIgniter4/actions/runs/20376659038/job/58556861626 Maybe try to rebase? |
5ed5f12 to
694ee32
Compare
5 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference : https://github.com/codeigniter4/CodeIgniter4/actions/runs/20359640614/job/58502356892?pr=9847
Checklist: