feat: Add support for HTTP status in ResponseCache#9855
feat: Add support for HTTP status in ResponseCache#9855michalsn merged 3 commits intocodeigniter4:4.7from
ResponseCache#9855Conversation
|
Hi there, sk757a! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
|
Nice addition. I'm not sure whether this should be classified as a bug or a feature, but I'm fine treating it as a feature. Please add a changelog entry here: https://github.com/codeigniter4/CodeIgniter4/blob/4.7/user_guide_src/source/changelogs/v4.7.0.rst#libraries |
ResponseCache
|
Thank you @sk757a |
Glad to help. I hope this is just the beginning. |
Description
Implementation of storing and returning HTTP status for a cached response.
Currently, ResponseCache always returns 200 OK, regardless of the controller's response.
Checklist: