chore: remove redundant PHPStan baseline cleanup#9866
Merged
michalsn merged 3 commits intocodeigniter4:developfrom Jan 3, 2026
Merged
chore: remove redundant PHPStan baseline cleanup#9866michalsn merged 3 commits intocodeigniter4:developfrom
michalsn merged 3 commits intocodeigniter4:developfrom
Conversation
Member
|
It's possible we no longer need manual cleanup of the .neon files. Please check it on your local machine. |
composer phpstan:baseline script
Contributor
Author
|
@michalsn, thank you for your sharp eye and guidance. |
paulbalandan
approved these changes
Jan 3, 2026
michalsn
approved these changes
Jan 3, 2026
Member
|
Thank you @datamweb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the script uses
bash -cto runrmandtouchcommands. While this works for many developers on Windows who have configured Git Bash in their system's PATH, it creates an implicit dependency. New contributors or those with a different setup may encounter errors, creating a barrier to entry.It has been identified that the
split-phpstan-baselinecommand (provided byshipmonk/phpstan-baseline-per-identifier) already incorporates its own logic todeleteOrphanedFilesas part of its process. This means the explicit cleanup step performed beforesplit-phpstan-baselineis unnecessary and duplicative.https://github.com/shipmonk-rnd/phpstan-baseline-per-identifier/blame/b997803a60f1f604b9fe0aed5d6d1edead010190/src/BaselineSplitter.php#L240-L274
See : #9865 (comment)
Checklist: