Skip to content

refactor: Superglobals - remove property promotion and fix PHPDocs#9871

Merged
paulbalandan merged 1 commit intocodeigniter4:4.7from
paulbalandan:superglobals-refactor
Jan 6, 2026
Merged

refactor: Superglobals - remove property promotion and fix PHPDocs#9871
paulbalandan merged 1 commit intocodeigniter4:4.7from
paulbalandan:superglobals-refactor

Conversation

@paulbalandan
Copy link
Member

Description
After #9858, I am updating the phpstan extension and noted some improvements.

  • CPP is now redundant given we use the set methods in the constructor.
  • Fix PHPDocs in (get|set)FilesArray returning previously a single file array

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan merged commit 516c50d into codeigniter4:4.7 Jan 6, 2026
49 checks passed
@paulbalandan paulbalandan deleted the superglobals-refactor branch January 6, 2026 04:45
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants