Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
The test failures are due to |
It seems to me that APCu extension just needs to be installed in the CI environment. |
Please add then in test-phpunit.yml under the extra-extensions parameter of cache-live-tests job. |
|
APCu enabled. Can't get why tests failed. |
|
Probably |
|
By default, APCu is disabled in CLI, see: https://www.php.net/manual/en/apcu.configuration.php#ini.apcu.enable-cli We can use: ini-values: apc.enable_cli=1But this should be abstracted, like other options. |
This. Forgot about this parameter.
Could you elaborate a bit? At first glance, I just wanted to add |
|
I don't think it will have any effect if you add it to the The proper way to add ini settings to setup-php is by So I think we should have an abstract value, like: CodeIgniter4/.github/workflows/reusable-phpunit-test.yml Lines 160 to 166 in 12cf2b4 |
I was in a hurry and made a mistake. The composer parameters are of course irrelevant. I rather meant something like this Thanks for the clarification. I'll look into this now. |
|
Time dependent test fail. May be just rerun? |
paulbalandan
left a comment
There was a problem hiding this comment.
Can you also add ext-apcu in the suggested extensions in composer.json? Both root composer.json and framework composer.json
|
Thank you @sk757a |
Description
This PR enhance the framework's capabilities by adding a new caching driver based on the APCu extension.
Checklist: