Skip to content

fix: Fixed relative paths in .gitignore#9929

Open
neznaika0 wants to merge 1 commit intocodeigniter4:developfrom
neznaika0:fix/gitignore
Open

fix: Fixed relative paths in .gitignore#9929
neznaika0 wants to merge 1 commit intocodeigniter4:developfrom
neznaika0:fix/gitignore

Conversation

@neznaika0
Copy link
Contributor

Description
Fixes #9873

  • It is rare case when phpunit is located at the root. The previous rule ignored everything - (sub)directories and files - this is incorrect.

  • Additionally updated paths that are always located at the root (writable, user_guide_src)

  • vendor/ can be in internal subfolders - left as it is

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member

btw, is the admin/starter|framework needs update as well?

writable/session/*

writable/session/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Ignoring abstract "phpunit"

4 participants