Add MySQL 8 keywords, date literal highlighting, and hint coverage to SQL mode#7150
Open
rlaiola wants to merge 2 commits intocodemirror:masterfrom
Open
Add MySQL 8 keywords, date literal highlighting, and hint coverage to SQL mode#7150rlaiola wants to merge 2 commits intocodemirror:masterfrom
rlaiola wants to merge 2 commits intocodemirror:masterfrom
Conversation
Member
|
Could you move the completion tests into mode/sql/test.js, instead of putting them in the core test file? |
Author
Member
|
Well, no, having lint errors won't do, of course. Why aren't these tests regular |
Member
|
Also “The remaining messages are known CM5 test-runner warnings due to intentional global helpers” sounds like something an AI might say. Was this PR created using a language model? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR:
{d ...}escapes unsupported.