Update clang-format include order rules #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be including the sycl.hpp header from the sycl/ folder.
Changing from CL/sycl to sycl/sycl started forcing some header file reordering, which caused pre-commit failures in the CI. So I have changed the clang-format rules to better express what we want, which has then cause other formatting changes for files that were not already compliant to my dread will. * all "headers.hpp" * <third_party/includes.h> * <sycl/sycl.hpp> * <cppstdlibheaders> Other than that, changing the matmul header caused the `cl::` namespace to disappear, so was removed. Other formatting in the tuple_utils header started becoming a bit nasty so knowing that SYCL requires C++ 17, I changed to `decltype(auto)` for some of the function return types.
rafbiels
reviewed
Jan 24, 2025
Collaborator
rafbiels
left a comment
rafbiels
left a comment
There was a problem hiding this comment.
Nice one, thanks! I like the new .clang-format configuration as well - this was something I was thinking of having but never spent the time to figure out. Could you update the PR title and description to reflect also that change?
DuncanMcBain
changed the title
Member
Author
|
What I'll actually do is rewrite the commit message when I squash and merge just now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be including the sycl.hpp header from the sycl/ folder.