fix: SSH connection is terminated when agent is marked as disconnected/timed out #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workspace and/or agent status change should be printed on INFO level, because it is critical information that can help us debug transient changes that can disrupt the ssh connection.
convert from enum to sealed class in order to be able to store the workspace parameter which will be used later to decide whether a workspace is reachable via ssh.
…d/timed out For a bit of context Coder Toolbox can establish an SSH connection when the workspace is in RUNNING state and agent is in READY state. If the connection is already established but for some reason the agent does not respond to pings, then the connectio is terminated by signaling Toolbox that the workspace changed the overall status to a non-reachable state. In reality the connection can still work. After some code research and testing it looks like coder ssh waits for the agent to be connecting before establishing the ssh connection. This allows us to mark the workspace as reachable as soon as it hits the RUNNING state regardless of the agent status. - resolves #246
fioan89
changed the title
spikecurtis
approved these changes
Jan 20, 2026
f0ssel
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a bit of context Coder Toolbox can establish an SSH connection when the workspace
is in RUNNING state and agent is in READY state. If the connection is already established
but for some reason the agent does not respond to pings, then the connection is terminated
by signaling Toolbox that the workspace changed the overall status to a non-reachable state.
In reality the connection can still work. After some code research and testing it looks like
coder ssh waits for the agent to be connecting before establishing the ssh connection. This
allows us to mark the workspace as reachable as soon as it hits the RUNNING state regardless
of the agent status.
The PR also changes the log level from debug to info for the lines that report the workspace and agent status.
This change should help with faster debugs in the future. Logs will not be spammed every 5 seconds with
this report, instead the line will be logging only when the workspace build changes.