🤖 fix: use correct tool policy for continue message after compaction #1270
+88
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a /compact command includes a continue message, the continue message was being queued with the compaction mode's tool policy (all tools disabled) instead of the intended execution mode's tool policy. The bug existed since the feature was first implemented in PR #650 (Nov 21). The code spread compaction options into the queued message, which included the disabled-all tool policy from compact mode. Fix: Add 'mode' field to ContinueMessage type so the backend can derive the correct tool policy via modeToToolPolicy() instead of inheriting from compaction options. Files changed: - src/common/types/message.ts: Add mode field to ContinueMessage - src/browser/utils/chatCommands.ts: Set mode when building continueMessage - src/browser/hooks/useResumeManager.ts: Preserve mode during resume - src/node/services/agentSession.ts: Use modeToToolPolicy(continueMessage.mode)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
/compactcommand includes a continue message, the continue message was being queued with the compaction mode's tool policy (all tools disabled) instead of the intended execution mode's tool policy.Root Cause
The bug existed since the feature was first implemented in PR #650 (Nov 21). The code spread compaction options into the queued message, which included the disabled-all tool policy from compact mode.
Fix
Add
modefield toContinueMessagetype so the backend can derive the correct tool policy viamodeToToolPolicy()instead of inheriting from compaction options.Changes
src/common/types/message.ts: Addmodefield toContinueMessagesrc/browser/utils/chatCommands.ts: Set mode when building continueMessagesrc/browser/hooks/useResumeManager.ts: Preserve mode during resumesrc/node/services/agentSession.ts: UsemodeToToolPolicy(continueMessage.mode)src/node/services/agentSession.continueMessageToolPolicy.test.ts: Regression testGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high