🤖 fix: use functional updates in ReviewControls to avoid stale closures

[ammar-agent]

Summary

Fix a regression where changing the diff base in the Review tab doesn't update the UI. The handlers were capturing stale filters props in closures.

Background

When calling setFilters({ ...filters, diffBase: value }), the filters object is captured at render time. While React Compiler should handle this, using functional updates is the idiomatic and safer approach that guarantees correct behavior.

Implementation

• Changed onFiltersChange type to accept functional updates: (filters: ReviewFilters | ((prev: ReviewFilters) => ReviewFilters)) => void
• Converted all filter handlers to use functional form:

  // Before
  onFiltersChange({ ...filters, diffBase: value })
  
  // After  
  onFiltersChange((prev) => ({ ...prev, diffBase: value }))

• Added data-testid props for testing

Validation

• Added UI integration tests that verify base value updates correctly when changed via updatePersistedState
• Tests pass locally: TEST_INTEGRATION=1 bun x jest tests/ui/reviewBaseSelector.integration.test.ts

---

Generated with mux • Model: anthropic:claude-opus-4-5 • Thinking: high • Cost: $13.69

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 83a2544919

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".