🤖 feat: support PDF attachments #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edfcb8fb8d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ibetitsmike
force-pushed
the
mike/attachments-pdf
branch
from
cb20bf0 to
029ee8d
Compare
ibetitsmike
force-pushed
the
mike/attachments-pdf
branch
from
029ee8d to
7c3342b
Compare
ethanndickson
added a commit
that referenced
this pull request
Jan 26, 2026
#1896 regressed #1146 by awaiting sendMessage before calling onWorkspaceCreated. This caused the 'Creating workspace' splash to block until sendMessage resolved, which waits for init to complete. For devcontainer/SSH runtimes, init can take minutes. Restore the fire-and-forget pattern: navigate immediately after workspace.create() succeeds. Draft input/attachments are now cleared only after sendMessage succeeds (via .then()), preserving them if the send fails. Added regression test that verifies onWorkspaceCreated is called before sendMessage resolves (using a never-resolving promise mock).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
## Summary Fixes a regression where the "Creating workspace" splash blocked until `sendMessage` completed. For devcontainer/SSH runtimes, this could take minutes since `sendMessage` waits for init (container build) to finish. ## Background **Regressed in #1896** ("feat: support PDF attachments") which changed `void api.workspace.sendMessage(...)` (fire-and-forget) to `await api.workspace.sendMessage(...)` and moved `onWorkspaceCreated` after it. This undid the fix from **#1146** ("perf: exit splash screen immediately after workspace.create()"). ## Implementation - Move `onWorkspaceCreated` and `setIsSending(false)` to immediately after `workspace.create()` succeeds - Change `sendMessage` back to fire-and-forget with `void` - Clear draft input/attachments only after `sendMessage` succeeds (via `.then()`), preserving them if the send fails ## Validation - Added regression test that verifies `onWorkspaceCreated` is called before `sendMessage` resolves (using a never-resolving promise mock) - Existing tests pass - `make static-check` passes --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$7.42`_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=7.42 -->
ethanndickson
added a commit
that referenced
this pull request
Jan 26, 2026
## Summary Fixes a regression where the "Creating workspace" splash blocked until `sendMessage` completed. For devcontainer/SSH runtimes, this could take minutes since `sendMessage` waits for init (container build) to finish. ## Background **Regressed in #1896** ("feat: support PDF attachments") which changed `void api.workspace.sendMessage(...)` (fire-and-forget) to `await api.workspace.sendMessage(...)` and moved `onWorkspaceCreated` after it. This undid the fix from **#1146** ("perf: exit splash screen immediately after workspace.create()"). ## Implementation - Move `onWorkspaceCreated` and `setIsSending(false)` to immediately after `workspace.create()` succeeds - Change `sendMessage` back to fire-and-forget with `void` - Clear draft input/attachments only after `sendMessage` succeeds (via `.then()`), preserving them if the send fails ## Validation - Added regression test that verifies `onWorkspaceCreated` is called before `sendMessage` resolves (using a never-resolving promise mock) - Existing tests pass - `make static-check` passes --- _Generated with `mux` • Model: `anthropic:claude-opus-4-5` • Thinking: `high` • Cost: `$7.42`_ <!-- mux-attribution: model=anthropic:claude-opus-4-5 thinking=high costs=7.42 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors chat attachments plumbing from the confusing
imagePartsnaming to genericfileParts, and extends attachments beyond images to include PDFs (application/pdf).Implementation
imageParts→fileParts,ImagePart→FilePart,MuxImagePart→MuxFilePart.inputAttachments:*and generalized UI toChatAttachments.getModelCapabilities()helper backed bymodels.jsonto detectsupports_pdf_inputandmax_pdf_size_mb.Validation
make static-checkRisks
inputImages:*drafts won’t restore).Generated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$7.74