🤖 feat: add Geist font for Windows/Linux #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on macOS - Install geist package for font files - Bundle Geist Sans and Geist Mono variable fonts - Update font-family stack to prefer -apple-system (San Francisco) on macOS - Geist fonts will be used on Windows and Linux - Use font-display: swap for better loading performance _Generated with `mux`_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Move geist package to devDependencies (only used at build time) - Add scripts/copy-fonts.sh to copy fonts from node_modules to public/ - Integrate font copying into Makefile build-static target - Font files are now copied during build, not checked into git This keeps the geist package as the source of truth for font files while avoiding duplication in the repository.
Font files are copied from node_modules during build and should not be committed to the repository.
Variable fonts already include all weights (100-900), so individual weight files are not needed.
Absolute paths (/fonts/...) resolve to file:///fonts/... in packaged Electron builds. Use relative paths (./fonts/...) so Vite resolves them correctly relative to the CSS file. Thanks to Codex for catching this!
Revert to absolute paths (/fonts/...) as relative paths don't work with Storybook and Vite's asset handling. The base: './' in vite config ensures these resolve correctly in packaged builds. Also fix shell script indentation to use tabs.
Member
Author
|
@codex The font path issue has been investigated. Absolute paths are required for Storybook and dev server to work correctly. The |
|
To use Codex here, create an environment for this repo. |
shfmt expects 2 spaces for line continuations, not tabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the font configuration to use San Francisco on macOS and Geist on Windows/Linux.
Changes
geistpackage and bundled Geist Sans and Geist Mono variable fontsglobals.css--font-primaryto prefer-apple-system(San Francisco) first, then fall back toGeist--font-monospaceto prefer macOS system monospace fonts, thenGeist MonoImplementation
The font-family stack now works as follows:
-apple-system(San Francisco) for UI andMonaco/Menlofor monospaceGeistfor UI andGeist Monofor monospaceFont files are bundled in
public/fonts/and loaded withfont-display: swapfor better performance.Generated with
mux