🤖 refactor: disable Chromatic snapshots for Shimmer animations #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
force-pushed
the
disable-shimmer-storybook
branch
from
1692558 to
674a39a
Compare
The Shimmer component uses infinite animations which cause visual regression issues in Chromatic. Adding data-chromatic="ignore" to the component itself tells Chromatic to ignore this element in all stories. This approach: - Keeps all stories enabled for visual testing - Only ignores the animated Shimmer element pixels - Works automatically in any story that uses Shimmer
kylecarbs
force-pushed
the
disable-shimmer-storybook
branch
from
674a39a to
4964a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Shimmer component uses infinite animations (
repeat: Number.POSITIVE_INFINITY) which cause visual regression test failures in Chromatic. Each snapshot shows the animation at a different point, causing spurious diffs.Changes:
ReasoningMessage.stories.tsx(all stories use Shimmer)ActiveWorkspaceWithChatstory (includes streaming reasoning messages with Shimmer)Why
disableSnapshotinstead of other approaches:pauseAnimationAtEnd- animation loops infinitelyGenerated with
mux