🤖 fix: unify chat input and commands flow #704
Merged
+516
−328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
ammar-agent
force-pushed
the
slash-commands-chat-flow-fix-pr
branch
3 times, most recently
from
2288a76 to
05d4802
Compare
- Toast was only rendered for workspace variant, so slash command toasts (e.g., /providers help) were invisible in creation mode - Now renders a single ChatInputToast that shows either: - Shared toast from slash commands (priority) - Creation-specific toast as fallback - Command suggestions were already unified, this completes parity
The CommandSuggestions popup was being clipped by overflow:hidden on parent containers in creation mode. In workspace mode, ChatInput is positioned outside the overflow-hidden scroll container. Solution: Pass anchorRef to CommandSuggestions when in creation mode. When anchorRef is provided, the component uses createPortal to render to document.body with fixed positioning relative to the anchor element. This escapes the overflow:hidden containers and ensures suggestions are visible in both variants.
ammar-agent
force-pushed
the
slash-commands-chat-flow-fix-pr
branch
from
111250a to
93c016b
Compare
ethanndickson
added a commit
that referenced
this pull request
Dec 9, 2025
Fixes a regression introduced in #784 where slash commands were accidentally removed from creation mode during the ORPC migration. Supporting global commands like /providers in creation mode was originally introduced in #704. This PR restores that functionality with an improvement: workspace-only commands (clear, truncate, compact, fork, new) are now filtered from suggestions in creation mode rather than just showing an error toast when executed. Changes: - Restore CommandSuggestions in creation mode with portal rendering - Filter workspace-only commands from suggestions based on variant - Unify toast handling to show slash command feedback in both modes - Extract WORKSPACE_ONLY_COMMANDS to shared constant to avoid duplication
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
Fixes a regression introduced in #784 where slash commands were accidentally removed from creation mode during the ORPC migration. Supporting global commands like `/providers` in creation mode was originally introduced in #704. This PR restores that functionality with an improvement: workspace-only commands (`clear`, `truncate`, `compact`, `fork`, `new`) are now filtered from suggestions in creation mode rather than just showing an error toast when executed. ## Changes - Restore `CommandSuggestions` in creation mode with portal rendering (to escape `overflow:hidden` containers) - Filter workspace-only commands from suggestions based on variant - Unify toast handling to show slash command feedback in both modes - Extract `WORKSPACE_ONLY_COMMANDS` to shared constant to avoid duplication between suggestion filtering and command execution _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors chat command handling to unify behavior between workspace chat and creation flow. Supports global commands like /providers in creation mode. Reduces LoC by consolidating utility functions.