🤖 fix: prevent unbound variable errors from system bashrc #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds --norc to .SHELLFLAGS in Makefile to prevent bash from sourcing /etc/bash.bashrc or ~/.bashrc during build commands. This fixes an issue where system bashrc files containing strict checks (like checking PS1 with set -u) would cause build failures or log spam because make runs shells with -u (nounset).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents
makecommands from sourcing system/etc/bash.bashrcor~/.bashrcby adding--norcto.SHELLFLAGS.This resolves issues where system bash configurations reference unbound variables (like
PS1) which cause failures when running undermake's strictset -u(nounset) mode.Fixes: /etc/bash.bashrc: line 7: PS1: unbound variable