Skip to content

🤖 ci: parallelize macOS PR builds by skipping signing setup #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 2 commits into from
Dec 2, 2025
Merged

🤖 ci: parallelize macOS PR builds by skipping signing setup #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f26bed
🤖 ci: parallelize macOS PR builds by skipping signing setup
ammar-agent Dec 2, 2025
27bbd01
ci: skip bun cache restore when node_modules hits
ammar-agent Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/setup-mux/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ runs:
${{ runner.os }}-${{ runner.arch }}-bun-${{ steps.bun-version.outputs.version }}-node-modules-

- name: Cache bun install cache
if: steps.cache-node-modules.outputs.cache-hit != 'true'
id: cache-bun-install
uses: actions/cache@v4
with:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ jobs:

- uses: ./.github/actions/setup-mux

# Skip signing setup for PRs - electron-builder skips signing anyway,
# but setting CSC_LINK forces our Makefile to build sequentially.
# Without CSC_LINK, x64 and arm64 build in parallel (~90s savings).
- name: Setup code signing
if: github.event_name != 'pull_request'
run: ./scripts/setup-macos-signing.sh
env:
MACOS_CERTIFICATE: ${{ secrets.MACOS_CERTIFICATE }}
Expand All @@ -28,6 +32,7 @@ jobs:
AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }}

- name: Verify signing setup
if: github.event_name != 'pull_request'
run: |
if [ -n "${CSC_LINK:-}" ]; then
echo "✅ Code signing enabled"
Expand All @@ -39,8 +44,6 @@ jobs:

- name: Package for macOS
run: make dist-mac
env:
CSC_FOR_PULL_REQUEST: ${{ github.event.pull_request.number == 234 }}

- name: Upload macOS DMG (x64)
uses: actions/upload-artifact@v4
Expand Down