🤖 fix: voice input keybind improvements #846
Merged
+53
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
ammar-agent
force-pushed
the
voice-input-mode
branch
6 times, most recently
from
8eef247 to
21afe5b
Compare
More correct by construction: the hook owns the state machine, so it should own the keyboard interactions for that state. - Add useRecordingKeybinds option to useVoiceInput - Track spaceHeld in a ref that persists correctly - Listeners added only when state === 'recording', auto-cleanup on state change - Removes duplicate keybind code from ChatInput
ammar-agent
force-pushed
the
voice-input-mode
branch
from
21afe5b to
e388b22
Compare
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated with mux
Fixes several voice input UX issues:
Space key hold causing gibberish sends
spaceHeldin a ref, require release before space can trigger sendCtrl+D not working globally during recording
useVoiceInputhook (owns state machine, should own keybinds)matchesKeybind(e, KEYBINDS.TOGGLE_VOICE_INPUT)as source of truthSpace requiring focus to send
addEventListener(..., true)) to intercept before focused elements consume the eventDesign is more correct by construction: listeners only added when
state === 'recording', auto-cleanup on state change.