🤖 fix: disable extended thinking for workspace name generation #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating workspace names with reasoning models (e.g., claude-opus-4-5), the API sometimes returns thinking content that breaks JSON parsing, causing 'Invalid JSON response' errors. Fix: Explicitly pass providerOptions with thinking disabled to generateObject(). - Add buildProviderOptions(modelString, 'off') to ensure no thinking content - Add ModelProvider interface for easier testing without full AIService - Add unit/integration tests for workspace title generation - Add testUtils.ts with minimal model creation for tests
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
…tion When workspace name generation fails (e.g., proxy returns invalid JSON): - Fall back to placeholder name instead of blocking workspace creation - Show warning toast with error details - Log raw response body for debugging proxy issues Also: - Add warning toast type with theme-aware colors - Explicitly disable extended thinking for generateObject calls
Member
|
Not actually the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating workspace names with reasoning models (e.g., claude-opus-4-5), the API sometimes returns thinking content that breaks JSON parsing, causing 'Invalid JSON response' errors.
Fix: Explicitly pass providerOptions with thinking disabled to
generateObject().buildProviderOptions(modelString, 'off')to ensure no thinking contentModelProviderinterface for easier testing without full AIServicetestUtils.tswith minimal model creation for testsGenerated with
mux