feat: unify Electron and CLI with shared oRPC API server #878
Conversation
ThomasK33
force-pushed
the
cli-api-orpc-proxy
branch
from
9602beb to
a808f8a
Compare
ThomasK33
force-pushed
the
unified-api-server
branch
from
78a30ac to
18d85b3
Compare
ThomasK33
force-pushed
the
unified-api-server
branch
5 times, most recently
from
fe68498 to
15d325c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
unified-api-server
branch
from
15d325c to
45fd635
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
unified-api-server
branch
from
45fd635 to
0e19846
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ThomasK33
force-pushed
the
unified-api-server
branch
from
0e19846 to
c6fc07a
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
unified-api-server
branch
from
c6fc07a to
3602f01
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Lines 155 to 159 in 3602f01
Store connectable address in server lockfile
When the server binds to a wildcard host (e.g., mux server --host 0.0.0.0 so remote clients can reach it), the lockfile advertises baseUrl exactly as bound. That yields http://0.0.0.0:<port> here, which is not a routable address for HTTP clients. Because mux api now auto-discovers the running server via that lockfile, all CLI commands will fail to connect whenever the server is started on 0.0.0.0. The baseUrl written to the lockfile should use an address clients can actually dial (e.g., localhost or the real interface) instead of the bind wildcard.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Electron now runs an HTTP/WS API server on 127.0.0.1 alongside the existing MessagePort transport. Both transports share the same oRPC router instance with auth middleware. - Add ServerLockfile to manage ~/.mux/server.lock for discovery - Extend ServerService with startServer/stopServer lifecycle - Move orpcServer.ts to src/node/orpc/server.ts (shared module) - Electron generates auth token, injects into both transports - CLI server checks lockfile to prevent conflicts - CLI api auto-discovers running server via lockfile Env vars: - MUX_SERVER_AUTH_TOKEN: Override auth token - MUX_SERVER_PORT: Fixed port (default: random) - MUX_NO_API_SERVER=1: Disable API server in Electron
ThomasK33
force-pushed
the
unified-api-server
branch
from
3602f01 to
86489da
Compare
1 participant
Summary
127.0.0.1alongside the existing MessagePort transport~/.mux/server.lockChanges
ServerLockfileservice for server discovery and conflict detectionServerServicewithstartServer/stopServerlifecycle methodsorpcServer.tstosrc/node/orpc/server.ts(shared module)Environment Variables
MUX_SERVER_AUTH_TOKENMUX_SERVER_PORTMUX_NO_API_SERVER=1Test plan
make typecheckpassesmake lintpassesGenerated with mux