Skip to content

🤖 fix: use double RAF in jumpToBottom for reliable scroll position #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 2 commits into from
Dec 3, 2025
Merged

🤖 fix: use double RAF in jumpToBottom for reliable scroll position #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38208a9
🤖 fix: use double RAF in jumpToBottom for reliable scroll position
ammar-agent Dec 3, 2025
f711b65
chore: fix formatting in cli/index.ts (pre-existing issue)
ammar-agent Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/browser/hooks/useAutoScroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,18 @@ export function useAutoScroll() {
}, []); // No deps - ref ensures we always check current value

const jumpToBottom = useCallback(() => {
if (contentRef.current) {
contentRef.current.scrollTop = contentRef.current.scrollHeight;
setAutoScroll(true);
}
if (!contentRef.current) return;

// Double RAF: First frame for DOM updates (async highlighting, image loads),
// second frame to scroll after layout is complete
requestAnimationFrame(() => {
requestAnimationFrame(() => {
if (contentRef.current) {
contentRef.current.scrollTop = contentRef.current.scrollHeight;
}
});
});
setAutoScroll(true);
}, []);

const handleScroll = useCallback((e: React.UIEvent<HTMLDivElement>) => {
Expand Down
5 changes: 4 additions & 1 deletion src/cli/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ if (subcommand === "run") {
process.argv.splice(2, 1);
// eslint-disable-next-line @typescript-eslint/no-require-imports
require("./api");
} else if (subcommand === "desktop" || (isElectron && (subcommand === undefined || isElectronLaunchArg))) {
} else if (
subcommand === "desktop" ||
(isElectron && (subcommand === undefined || isElectronLaunchArg))
) {
// Explicit `mux desktop`, or Electron runtime with no subcommand / Electron launch args
launchDesktop();
} else {
Expand Down
Loading