🤖 fix: remove duplicate caught-up event in onChat subscription #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
The onChat handler was pushing a caught-up event after replayHistory, but replayHistory already sends caught-up at the end of emitHistoricalEvents. This resulted in two caught-up events being sent to the client. Removed the duplicate push to clean up the code.
ammar-agent
force-pushed
the
fix-maximum-update-depth-warning
branch
from
5f3574b to
2d05306
Compare
ammar-agent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
onChathandler was pushing acaught-upevent afterreplayHistory, butreplayHistoryalready sendscaught-upat the end ofemitHistoricalEvents. This resulted in twocaught-upevents being sent to the client.Changes
push({ type: "caught-up" })from the router sincesession.replayHistory()already sends itTesting
resumeStream.test.ts)WorkspaceStore.test.tspassesGenerated with
mux