Improve session expiry UX with login prompt and automatic recovery #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EhabY
force-pushed
the
oauth-failure-handling
branch
from
9f9b099 to
87cd9c1
Compare
- Show "Log In" button when session expires instead of just a message - Keep deployment info after session expiry for easier re-login - Automatically recover session when tokens are refreshed in another window - Validate OAuth scopes to detect permission changes - Consolidate duplicated OAuth constants
EhabY
force-pushed
the
oauth-failure-handling
branch
from
87cd9c1 to
ae4df51
Compare
code-asher
approved these changes
Jan 20, 2026
src/deployment/deploymentManager.ts
Outdated
|
|
||
| if (auth) { | ||
| this.client.setCredentials(auth.url, auth.token); | ||
| if (this.contextManager.get("coder.authenticated")) { |
Member
There was a problem hiding this comment.
nbd but would calling this.isAuthenticated() make sense here since it does the same thing?
| this.refresh(); | ||
| } | ||
|
|
||
| public dispose() { |
Member
There was a problem hiding this comment.
Feels like if we have dispose and clear they should do different things, like is dispose meant to ensure the provider cannot be used again or something? In which case maybe we can formalize that with a boolean check or something.
Collaborator
Author
There was a problem hiding this comment.
dispose meant to ensure the provider cannot be used again or something?
Indeed, I'll add a boolean check then!
code-asher
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #723