-
Notifications
You must be signed in to change notification settings - Fork 1k
Comprehensive Integration Test Suite #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive Integration Test Suite #140
Conversation
…mp-labs#136) - Change main() to a synchronous Click command - Introduce _async_main() for async ingest logic - Use asyncio.run(...) to properly await the async function
…ow-integration-tests
…/gitingest into flow-integration-tests
|
I wanted to provide some context regarding the previous failures on this PR:
However, the static directory was missing in the CI environment, resulting in the following error:
app.mount("/static", StaticFiles(directory="src/static"), name="static")
|
cyclotruc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RyanL2004 thank you very much for this work
I'll take a deeper look at the tests themselves very soon but there's an issue that needs to be tackled first:

The changes you made in main.py are breaking the web server
That makes me think that this is the first thing we should try to test:
- is the server runnable and is it possible to trigger an ingest?
Feel free to reach out on discord if you need any help in structuring those new tests
|
Hi @cyclotruc, After some troubleshooting, Root Cause:
Fix: I’ve updated static_dir = Path(__file__).parent / "static"
if static_dir.exists():
app.mount("/static", StaticFiles(directory=static_dir), name="static")
else:
print(f"Warning: Static directory '{static_dir}' does not exist. Skipping static file mount.")I may still make some modifications, based on your next feedback |
|
@RyanL2004 Hi sorry for the delay, finally got back to your PR thank you very much :) |
Please read #139
Overview
This PR introduces a robust integration test suite for GitIngest, covering critical functionalities and edge cases. These tests ensure the reliability, scalability, and correctness of the application.
What Does This PR Do?
1. Adds Comprehensive Tests
2. Simulates Concurrent Requests
3. Mocks Template Rendering
4. Improves Code Coverage
5. Ensures Graceful Error Handling
How Does It Work?
What Does It Test?
1. End-to-End Flows
2. Error Handling
3. Performance
4. Scalability
Why Is This Critical?
Conclusion
This PR significantly enhances GitIngest’s testing framework, ensuring robustness, reliability, and scalability. It provides a foundation for future development with confidence in the system’s core functionalities.