refactor: rename clone to clone_repo and consolidate schema & utility modules #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipchristiansen
force-pushed
the
refactor/extract-schemas-and-rename-clone
branch
from
048bd6d to
7cadf8e
Compare
… modules - Rename `clone` to `clone_repo` for clarity - Move functions from `cloning` to `utils.git_utils`: - `_check_repo_exists` -> `check_repo_exists` - `fetch_remote_branch_list` remains `fetch_remote_branch_list` - `_run_command` -> `run_command` - `check_git_installed` -> `ensure_git_installed` - Remove the now-unused `_get_status_code` function - Move `exceptions.py` into `utils` - Create a new `schemas` package: - `FileSystemNode`, `FileSystemNodeType`, `FileSystemStats` - `CloneConfig`, `IngestionQuery` - Move `_get_encoding_list` and `is_textfile` to `utils.file_utils` - Update all references, imports, and tests accordingly
filipchristiansen
force-pushed
the
refactor/extract-schemas-and-rename-clone
branch
from
7cadf8e to
d04c311
Compare
cyclotruc
approved these changes
Mar 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the Gitingest codebase to improve clarity and maintainability:
Function Renaming:
cloneis renamed toclone_repofor more explicit naming._check_repo_exists,_run_command, andcheck_git_installedare moved and renamed ingitingest.utils.git_utils.Schema Consolidation:
FileSystemNode,FileSystemNodeType,FileSystemStats,CloneConfig,IngestionQuery) are extracted into a dedicatedgitingest.schemaspackage.Utility Cleanup:
_get_encoding_listandis_textfilenow reside ingitingest.utils.file_utils._get_status_codefunction.exceptions.pyintogitingest.utils.exceptions.References & Tests:
These updates streamline the codebase and reduce duplication, making the package easier to extend and maintain.