feat/manual-max-file-size-input: Add option to manually input max file size

[krvspacetime]

Description

Added a toggle to manually input the max file size instead of using the slider.

Major changes:

• Files modified:

  • git_form.jinja

  • index.py

  • process_query.py

  • utils.js

• Added three form values / new params in the POST endpoint in index.pycalled:

  • use_manual_input: bool

  • max_file_size_manual: int

  • size_unit:str

    These are also added to the context in process_query.py

• Added three new inputs elements

  • checkbox: toggle use of slider vs. manual input

  • number: accepts manual file size in by manually inputing a value of using the increment/decrement triggers

  • radio: switch between accepted file sizes betweenkb or mb

• Keep new form/input states after receving results and submitting form

  • Added a function in utils.js called restoreFormState to keep current input/form values after a successfull POST request

Minor changes

• Removed console log in changePatternfunction in git_form.jinja

• Reduced height of the absolute div (shadow effect) at large screens to 90% (lg:h-90% sm:h-fulll)) using media query in Tailwind to compensate to the slight change in dimesion of the div containg the form due to the addition of the new input element

• Removed unused variable minp in utils.js

• Added new context values in the home page to pass in default values called default_file_size_manual, use_manual_input and size_unit

[cyclotruc]

Hi @krvspacetime thank you for your contribution

I see some tests not passing

Regarding the changes, while I think it's a good idea to have the value editable with a text box, I think I want to keep the slider

I think the simplest way to keep both would be to make the value of the current slider editable by clicking it

what do you think?

[krvspacetime]

Hello @cyclotruc, you're welcome and thank you for the feedback.

I see some tests not passing

I think some of it is because I have to update the test_flow_ingegration.py and include the new form data values I added where necessary.

Regarding the changes, while I think it's a good idea to have the value editable with a text box, I think I want to keep the slider

I think the simplest way to keep both would be to make the value of the current slider editable by clicking it

The slider is actually still there, it is set as the default way to input the max file size. The input I added only shows when toggled.

I think the simplest way to keep both would be to make the value of the current slider editable by clicking it

It's funny because this is actually what I tried initially. I simply replaced the span with an input that can be edited when clicked and then made a function to reverse the log_slider_to_size / logSliderToSize functions so the slider position can be calculated. Is that what you meant? If this is what you prefer, I can work on it.