feat: Direct max file size input #255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e max file size Introduce a text input field for file size in the git form to allow manual entry alongside the slider. Update the slider logic to handle input changes and ensure synchronization between the slider and the input field. This improves user experience by providing more flexibility in setting file size limits.
- Add support for decimal precision in file size input by converting max_file_size from int to loat. This allows users to specify exact file sizes with decimal values, improving flexibility and accuracy. - Update the schema, form handling, and UI elements to ensure consistent behavior and proper formatting of decimal values.
- Modify slider_position and �xact_file_size to handle float values in query processing - Adjust slider step to �ny in the template to allow decimal increments - Refactor logSliderToSize and related functions in utils.js to support decimal precision
Contributor
|
Thank you for the PR @krvspacetime What is the motivation for this? When is this useful? |
Member
|
@krvspacetime Hi I'm going to close this PR for clarity in the repo but if you have a legitimate point please tell us here and I'll be happy to reopen this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct Max File Size Input Feature
Overview
This PR implements a direct file size input feature that allows user to input values for the max file size with decimal precision (e.g., "1.5kb" or "2.75mb"). The implementation changes the file size handling from integer-based to float-based throughout the application.
Changes
1. Backend
max_file_sizeparameter type frominttofloatacross multiple files:query_parsing.pyingestion_schema.pyentrypoint.pyquery_processor.py2. Frontend
git_form.jinjato include a text input that allows users to directly type file size values3. Javascript Utils
utils.js:formatSizefunction to properly display file sizes with appropriate unitsmaxp,minv,maxvvariables available to the global scope they are being used in multiple areas repeatedlyNOTE: A lof of the diffs in
utils.jsare simply the single quotes being turned to double quotes because of my formatter.