Skip to content

Fix: --include-pattern incorrectly filters directories leading to empty output #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ccwq wants to merge 1 commit into from
Closed

Fix: --include-pattern incorrectly filters directories leading to empty output #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/gitingest/ingestion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,13 @@ def _process_node(

if query.ignore_patterns and _should_exclude(sub_path, query.local_path, query.ignore_patterns):
continue

if query.include_patterns and not _should_include(sub_path, query.local_path, query.include_patterns):
continue

# If an inclusion pattern exists, apply it only to files.
# Directories should be traversed as long as they are not excluded,
# because they may contain files that need to be included.
if query.include_patterns and sub_path.is_file():
if not _should_include(sub_path, query.local_path, query.include_patterns):
continue

if sub_path.is_symlink():
_process_symlink(path=sub_path, parent_node=node, stats=stats, local_path=query.local_path)
Expand Down