Skip to content

Conversation

@ix-56h
Copy link
Contributor

@ix-56h ix-56h commented Jul 3, 2025

Topic

This should solve #369 and make the future logging easier for git api calls.

@ix-56h
Copy link
Contributor Author

ix-56h commented Jul 3, 2025

@filipchristiansen can you check the tests i think there's something wrong and i don't get it.
This happen since we use httpx instead of curl, this is probably an issue related to mock_exec = mocker.patch("asyncio.create_subprocess_exec", new_callable=AsyncMock) mock_process = AsyncMock()

@filipchristiansen filipchristiansen force-pushed the refactor_curl_to_request branch from 7cd017d to 7bfa241 Compare July 4, 2025 09:21
Copy link
Contributor

@NicolasIRAGNE NicolasIRAGNE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ix-56h ix-56h merged commit e023af3 into coderamp-labs:main Jul 6, 2025
19 checks passed
ix-56h added a commit to ix-56h/gitingest that referenced this pull request Jul 7, 2025
* replace curl by httpx

---------

Co-authored-by: Filip Christiansen <22807962+filipchristiansen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants