chore(utils): relax GitHub PAT validation (#380) #383
Conversation
* Drop `InvalidGitHubTokenError` * `validate_github_token` now emits a `UserWarning` instead of raising * Update tests to: * assert no warnings for valid tokens (via `recwarn`) * expect `UserWarning` for malformed tokens * Reduces false-positives and is future-proof if GitHub introduces new token formats Closes #380
| """ | ||
| if not re.fullmatch(_GITHUB_PAT_PATTERN, token): | ||
| raise InvalidGitHubTokenError | ||
| warnings.warn( |
There was a problem hiding this comment.
We don't need to validate the token with pattern matching and the warning is useless here i guess.
When the token is invalid (malformed or just invalid) we correctly handle the error:
I don't see why we validate and log the validation result here.
There was a problem hiding this comment.
I think the validation is informative. Just a little message saying "this does not look like a proper token, tokens usually start with gh_ blablabla" because yeah, believe me, i've seen too many people struggle with access tokens and just put their plain password or something
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
Hi there! We haven’t seen activity on this pull request for 45 days, so I’m marking it as stale. |
|
Hi there! We haven’t heard anything for 10 days, so I’m closing this pull request. Feel free to reopen if you’d like to continue working on it. Thanks! |
InvalidGitHubTokenErrorvalidate_github_tokennow emits aUserWarninginstead of raisingrecwarn)UserWarningfor malformed tokensCloses #380