feat: add settings menu #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nMenu - Introduced a new SettingsDialog component for managing application settings. - Updated ExcalidrawWrapper to handle the visibility of the SettingsDialog. - Enhanced MainMenu to include a Settings option that triggers the SettingsDialog. - Added corresponding styles for the SettingsDialog to ensure a cohesive UI experience.
- Added UserSettings interface and default settings for embed lock debounce time. - Integrated settings management into SettingsDialog, allowing users to adjust embed lock debounce time via a range input. - Updated normalizeCanvasData to preserve user settings when normalizing canvas data. - Improved styles for SettingsDialog to enhance user experience and organization.
- Introduced a memoized debounced function to manage scrolling state more efficiently. - Updated lockEmbeddables to accept appState for customizable debounce timing. - Modified ExcalidrawWrapper to integrate the new scrolling behavior, ensuring smoother user experience during scrolling events.
- Introduced background color and backdrop filter to the dialog wrapper for better visual appeal.
- Introduced a new Range component for user input, allowing adjustable values with labels and a value bubble. - Integrated the Range component into SettingsDialog for managing embed lock debounce time, enhancing user experience with visual feedback. - Added corresponding styles in Range.scss for improved UI consistency.
- Updated Range.scss and Range.tsx to implement BEM naming conventions for improved readability and maintainability. - Introduced new CSS variables for track colors to enhance customization. - Adjusted styles for input and labels to align with the new structure, ensuring consistent UI presentation.
- Replaced the specific embedLockDebounceTime handler with a more generic updateSetting function to streamline state updates for various settings. - Removed unused styles from SettingsDialog.scss to enhance code clarity and maintainability.
- Updated the calculation for embedLockDebounceTime in SettingsDialog to round the mapped value to the nearest multiple of 50, enhancing precision in user settings adjustments.
- Updated the label in SettingsDialog to "Embed Lock Time" for improved clarity and user understanding of the setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Settings menu in the main menu of pad.ws:
Currently, it allows to change the "lock time" of embeds when scrolling the view to move around:
