🔒 テストデータのドメインを RFC 2606 準拠の example.com/org/net に修正 #1775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
問題
spec/lib/statistics/aggregation_spec.rbのテストデータで、実在する可能性のあるドメイン(dojo1.com,dojo194.comなど)を使用していました。これらのドメインは実際に誰かが所有している可能性があり、テストデータとして不適切です。解決策
RFC 2606 で定められた、文書やテスト目的で予約されているドメインに修正しました:
example.comexample.orgexample.net変更内容
URL の修正
https://dojo1.com→https://example.com/dojo1https://dojo2.com→https://example.org/dojo2https://dojo3.com→https://example.net/dojo3https://dojo194.com→https://example.com/dojo194メールアドレスの修正
info@dojo1.com→info@dojo1.example.cominfo@dojo2.com→info@dojo2.example.comテスト結果
参考 URL
これらのドメインは IANA によって恒久的に予約されており、実際のインターネット上で使用されることはありません。
https://www.iana.org/domains/reserved
https://www.rfc-editor.org/rfc/rfc2606.html
https://www.rfc-editor.org/rfc/rfc6761.html