-
-
Notifications
You must be signed in to change notification settings - Fork 57
Add Firefox and Safari to Selenium CI suite #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 98.19% 99.27% +1.08%
==========================================
Files 7 7
Lines 277 277
==========================================
+ Hits 272 275 +3
+ Misses 5 2 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to expand the Selenium test suite to run on multiple browsers (Chrome, Firefox, and Safari) across different operating systems (Ubuntu and macOS), improving cross-browser compatibility testing.
- Parameterized the Selenium driver fixture to test with Chrome, Firefox, and Safari
- Refactored CI workflow to run Selenium tests on both Ubuntu and macOS runners with a matrix strategy
- Improved WebDriverWait usage to be more reliable by waiting for all elements instead of just one
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/conftest.py | Parameterized the driver fixture to instantiate Chrome, Firefox, and Safari with dynamic options and simplified headless configuration |
| tests/test_forms.py | Improved race condition handling by using presence_of_all_elements_located instead of waiting for one element then finding all |
| .github/workflows/ci.yml | Added matrix strategy for running Selenium tests on multiple OS (ubuntu-latest, macos-latest), removed Chrome-specific installation, and added codecov flags |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f7687fd to
bd2700b
Compare
No description provided.