Fix: Handle Empty Response Body in HTTP Error Cases #713
+179
−110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the Cohere API returns an HTTP error (e.g., 500 Internal Server Error) with an empty response body, the SDK crashes with a
JSONDecodeErrorinstead of properly handling the error. This occurs because the error handling code attempts to parse the empty response body as JSON without checking if it's parseable first.Error Flow
Production Error Example
From Sentry issue:
Solution
Introduced a
_safe_json_parse()helper function that gracefully handles JSON parsing failures: