-
Notifications
You must be signed in to change notification settings - Fork 28
feat(renovate): update renovate to use shared renovate-config #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,22 @@ | ||
| { | ||
| "extends": ["config:base", ":preserveSemverRanges", "schedule:weekly"], | ||
| "separateMajorMinor": true, | ||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | ||
| "extends": [ | ||
| "github>commercetools/renovate-config//composite/component-library" | ||
| ], | ||
| "rebaseWhen": "never", | ||
| "packageRules": [ | ||
| { | ||
| "sourceUrlPrefixes": ["https://github.com/gregberge/svgr"], | ||
| "matchSourceUrls": ["https://github.com/gregberge/svgr{/,}**"], | ||
| "groupName": "all svgr packages" | ||
| }, | ||
| { | ||
| "sourceUrlPrefixes": [ | ||
| "https://github.com/stylelint/stylelint-config-standard", | ||
| "https://github.com/stylelint/stylelint" | ||
| "matchPackageNames": [ | ||
| "stylelint", | ||
| "stylelint-config-standard", | ||
| "/^stylelint-/" | ||
| ], | ||
| "groupName": "all stylelint packages" | ||
| }, | ||
| { | ||
| "packagePatterns": ["*"], | ||
| "updateTypes": ["minor", "patch"], | ||
| "groupName": "all dependencies", | ||
| "groupSlug": "all" | ||
| }, | ||
| { | ||
| "matchPackageNames": ["html-loader"], | ||
| "allowedVersions": "<2.0.0" | ||
|
|
@@ -45,9 +42,5 @@ | |
| "allowedVersions": "<3.0.0" | ||
| } | ||
| ], | ||
| "lockFileMaintenance": { | ||
| "enabled": true | ||
| }, | ||
| "labels": ["π€ Type: Dependencies"], | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we remove this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's in the shared config now. https://github.com/commercetools/renovate-config/blob/700c5dcf53d675f8cd0779a6e0e15fc22d187758/default.json#L28 Questioning this a little as appKit has slightly different "stop labels" and I'm not sure if there are workflows that trigger off the labels. It would be nice to have label consistency across repos, but not sure if this is a can of worms we don't want to open right now.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd see the goal as dependency update cadence as the goal. Not expanding it to label consistency. One topic at a time :) |
||
| "ignoreDeps": ["slate", "slate-html-serializer", "slate-react"] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shared config has rebaseWhen: "conflicted". I notice AppKit also has rebaseWhen: "never". Not sure if this is common and we should change shared config or if we want this behavior to change. Conflicted doesn't seem like a bad option, but not sure why this was set to never originally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this as a repo decision then for now.