Skip to content

Conversation

@Vipul-Cariappa
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.94%. Comparing base (c357fd6) to head (42415e6).

Files with missing lines Patch % Lines
src/xinterpreter.cpp 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   81.94%   81.94%   -0.01%     
==========================================
  Files          21       21              
  Lines         853      864      +11     
  Branches       87       91       +4     
==========================================
+ Hits          699      708       +9     
- Misses        154      156       +2     
Files with missing lines Coverage Δ
src/xinterpreter.cpp 90.00% <83.33%> (-0.57%) ⬇️
Files with missing lines Coverage Δ
src/xinterpreter.cpp 90.00% <83.33%> (-0.57%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton changed the title [WIP] Adding OpenMP Kernels [test additional commit] Adding OpenMP Kernels + explicitly load libomp.so when required commit Jan 13, 2026
@anutosh491
Copy link
Collaborator

Hey @Vipul-Cariappa , thanks a lot for this !

I'll take out some time soon to go through this.

Initial thoughts

  1. I tried the wasm use case back in November or so. And though we can build libomp.so using emscripten, it's just how Jupyterlite and xeus is framed using pthreads this might not work. Pretty sure I wrote about my analysis in more detail on discord

  2. Something which looks concerning & I personally feel should be handled better is the amount of kernels. We already have 6 native kernels (3 C, 3 C++) and 6 wasm kernels (3 C, 3 C++)

Now for any specific use case like this if we have 6 more kernels coming in, that would be an insane amount of kernels to maintain. We already expect cuda, out-of-process, debugger enabled kernels to land ... and any other python-interop, clad etc kernels in future.

I think for a specific functionality use case, we should just present our best kernel forward. One with the latest C++ version.

I'm guessing @JohanMabille & @SylvainCorlay would also agree to the same ?!

@anutosh491 anutosh491 self-requested a review January 13, 2026 13:02
@Vipul-Cariappa Vipul-Cariappa changed the title [test additional commit] Adding OpenMP Kernels + explicitly load libomp.so when required commit [test additional commit] Adding OpenMP Kernels + explicitly load libomp.so Jan 13, 2026
@mcbarton
Copy link
Collaborator

@anutosh491 This PR is not one that is supposed to be merged in. It is just to test an additional commit on top of my existing PR #389 which had been open for a while now.

@Vipul-Cariappa
Copy link
Collaborator Author

@mcbarton why are the OSX tests failing? Doesn't it pass on your local machine?

@anutosh491
Copy link
Collaborator

those were just some thoughts ;)

@anutosh491 anutosh491 mentioned this pull request Jan 13, 2026
4 tasks
@mcbarton
Copy link
Collaborator

@mcbarton why are the OSX tests failing? Doesn't it pass on your local machine?

No the test doesn't pass locally for me on osx.

mcbarton and others added 2 commits January 14, 2026 12:04
remove the need to set env var PATH & LD_LIBRARY_PATH for omp kernels
@Vipul-Cariappa Vipul-Cariappa force-pushed the dev/mcbarton/Add-OpenMp-kernel branch from 3909d3a to 42415e6 Compare January 15, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants