Skip to content

Conversation

@matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Nov 5, 2024

Addresses #688.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@matthiasdiener
Copy link
Contributor Author

This is ready for review. A bit more context for not omitting the frame pointer: https://fedoraproject.org/wiki/Changes/fno-omit-frame-pointer

@xhochy
Copy link
Member

xhochy commented Nov 7, 2024

I'm generally in favor of it but asking myself whether we should set this globally in the compiler activation?

@matthiasdiener
Copy link
Contributor Author

I'm generally in favor of it but asking myself whether we should set this globally in the compiler activation?

FWIW, I'd be in favor of this as a (longer-term?) goal. In the meantime, would it make sense to add this flag just to this feedstock (at least for Python 3.12+)?

@matthiasdiener
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12187916771. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12187924818. Examine the logs at this URL for more detail.

@mdekstrand
Copy link

@xhochy I think globally enabling frame pointers for conda-forge would be a great idea, it's really hard to profile across an entire application without them (and AFAICT PyPI binary wheels are mixed in terms of enabling or disabling frame pointers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants