Skip to content

Conversation

@hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Nov 2, 2025

I really don't believe in fully ripping out zlib from conda-forge.

I think that a targeted approach is much better.

These patches are pretty close to something we could upstream.

xref: conda-forge/conda-forge.github.io#2638

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 2, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19004666526. Examine the logs at this URL for more detail.

…5.11.01.15.03.42

Other tools:
- conda-build 25.9.0
- rattler-build 0.49.0
- rattler-build-conda-compat 1.4.9
@hmaarrfk hmaarrfk changed the title Build Python 3.12 with zlib-ng on all platforms Build Python 3.14 with zlib-ng on all platforms Nov 2, 2025
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we build zlib-ng in compat mode and not carry these patches.

@mgorny
Copy link

mgorny commented Nov 3, 2025

Suddenly forcing zlib-ng on all Python users is bound to cause multiple regressions with no clear way back, short of pinning to an older Python 3.14 version.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Nov 3, 2025

pinning to an older Python 3.14 version.

This sounds like a very clear way for me.

Backends, and swaps, and build numbers are actually quite confusing for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants