Skip to content

Fix variable names and missing parameters in usage.md code examples #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i2y merged 2 commits into from
Oct 5, 2025
Merged

Fix variable names and missing parameters in usage.md code examples #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d70a529
Fix variable names and missing parameters in usage.md code examples
i2y Oct 4, 2025
97433ad
Merge branch 'main' into docs/correct-usage-examples
i2y Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions docs/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ from your_generated_code import eliza_pb2

class ElizaServiceImpl:
async def say(self, request: eliza_pb2.SayRequest, ctx: RequestContext) -> eliza_pb2.SayResponse:
return eliza_pb2.SayResponse(sentence=f"You said: {req.sentence}")
return eliza_pb2.SayResponse(sentence=f"You said: {request.sentence}")

async def converse(self, req: AsyncIterator[eliza_pb2.ConverseRequest]) -> AsyncIterator[eliza_pb2.ConverseResponse]:
async for msg in req:
yield eliza_pb2.ConverseResponse(sentence=f"You said: {msg.sentence}")
async def converse(self, request: AsyncIterator[eliza_pb2.ConverseRequest], ctx: RequestContext) -> AsyncIterator[eliza_pb2.ConverseResponse]:
async for message in request:
yield eliza_pb2.ConverseResponse(sentence=f"You said: {message.sentence}")
```

### WSGI Server
Expand All @@ -153,9 +153,9 @@ from your_generated_code import eliza_pb2

class ElizaServiceImpl:
def say(self, request: eliza_pb2.SayRequest, ctx: RequestContext) -> eliza_pb2.SayResponse:
return eliza_pb2.SayResponse(sentence=f"You said: {req.msg.sentence}")
return eliza_pb2.SayResponse(sentence=f"You said: {request.sentence}")

def converse(self, req: Iterator[eliza_pb2.ConverseRequest]) -> Iterator[eliza_pb2.ConverseResponse]:
for msg in req:
yield eliza_pb2.ConverseResponse(sentence=f"You said: {msg.sentence}")
def converse(self, request: Iterator[eliza_pb2.ConverseRequest], ctx: RequestContext) -> Iterator[eliza_pb2.ConverseResponse]:
for message in request:
yield eliza_pb2.ConverseResponse(sentence=f"You said: {message.sentence}")
```