-
Notifications
You must be signed in to change notification settings - Fork 4
Configure bump-my-version #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
stefanvanburen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat, hadn't seen bump-my-version before, but looks really useful for this sort of thing.
I realize this is automating a lot of releasing, but mind adding some context on steps to a RELEASE.md (similar to connect-go) (and linking to that from maybe README.md or whatever doc we have on development)? I think it'd be great to have simple steps for anyone to follow to create a new release.
justfile
Outdated
| uv run bump-my-version bump {{args}} | ||
| uv lock | ||
| cd protoc-gen-connect-python && uv lock | ||
| git commit -am "Bump version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also not sure if we want this automated, or maybe it'd be nice if the commit had more context ("Bump version to <version>")?
(Somewhat assuming that the runtime & plugin will stay the same version, although we could split them out for whatever reason.)
|
Doh my update to the do was unsaved/pushed. Will also work it into a RELEASE.md |
anuraaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, added the RELEASE.md doc with detailed steps
|
|
||
| Note the new version X.Y.Z in the updated files. | ||
|
|
||
| 3. Open a PR titled "Prepare for vX.Y.Z" ([Example PR #661](https://github.com/connectrpc/connect-go/pull/661)) and a description tagging all current maintainers. Once it's reviewed and CI passes, merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update to a connect-python URL after the next release
Sets up bumping flow to ease release