Fix discovery of only the last test in equally named suites#66
Open
ILikeRubberDuckies wants to merge 2 commits intoconnor4312:mainfrom
Open
Fix discovery of only the last test in equally named suites#66ILikeRubberDuckies wants to merge 2 commits intoconnor4312:mainfrom
ILikeRubberDuckies wants to merge 2 commits intoconnor4312:mainfrom
Conversation
Owner
|
This doesn't really work for me, notice L11 is missing a run indicator. 
I didn't do this initially because I think it's impossible to correctly support, but I would be happy to be wrong. If we don't support it correctly, then I think a better change would be having a diagnostic warning if duplicate suite names are encountered, e.g. https://github.com/microsoft/vscode-extension-test-runner/blob/90a5dc2008021620c506a4da241cae63afa962ff/src/controller.ts#L457 |
ILikeRubberDuckies
force-pushed
the
duckies/testsInSameSuitesFix
branch
from
e4c84bc to
5d9004e
Compare
ILikeRubberDuckies
force-pushed
the
duckies/testsInSameSuitesFix
branch
from
5d9004e to
8c0c523
Compare
Author
|
@connor4312 What do you think of this? Now the run indicators are being displayed correctly. I find having multiple locations for the same suite to be generally very beneficial, as Node allows hooks to only be applied to specific parts of the suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #65