Open
Conversation
Signed-off-by: Mike Interlandi <msinterlandi@gmail.com>
Signed-off-by: Mike Interlandi <msinterlandi@gmail.com>
Signed-off-by: Mike Interlandi <msinterlandi@gmail.com>
Signed-off-by: Mike Interlandi <msinterlandi@gmail.com>
Signed-off-by: Mike Interlandi <msinterlandi@gmail.com>
Signed-off-by: Mike Interlandi <msinterlandi@gmail.com>
Minterl
force-pushed
the
namespace-fix
branch
from
63738c1 to
d3454d4
Compare
Contributor
|
Thanks for this @Minterl There is a few issues with your PR - suggesting you run Also, for identifiers validation, Happy to review more in-depth once these two are out of the way. |
TinaMor
reviewed
Mar 10, 2025
| } | ||
|
|
||
| // Returns an error if name is invalid. | ||
| func validateNamespaceName(name string) error { |
| // Returns an error if name is invalid. | ||
| func validateNamespaceName(name string) error { | ||
| for _, c := range(name) { | ||
| if ( |
Contributor
There was a problem hiding this comment.
hyphen is allowed but not checked in the if statement.
Unexpected Behavior: "abc-123" (hyphen is neither allowed nor rejected explicitly, meaning it gets rejected)
Contributor
|
Hey @Minterl Are you interested in carrying this through the finish line? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses come concerns in #3851.
The decision not to enforce name validation in namespace.Remove is intentional as it is likely namespaces do exists that violate the validation rules. Not being able to easily delete them would present an issue on its own.