Skip to content

Conversation

@nathan-weinberg
Copy link
Collaborator

@nathan-weinberg nathan-weinberg commented Jun 30, 2025

Summary by Sourcery

Bump dependency versions for ramalama and llama-stack and standardize environment variable default syntax in the ramalama-run configuration

Enhancements:

  • Bump ramalama to 0.10.0 and llama-stack (including llama-stack-client) to 0.2.13 in requirements and project metadata
  • Standardize environment variable default assignments to use ':=' syntax in ramalama-run.yaml

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 30, 2025

Reviewer's Guide

This PR standardizes environment variable default syntax across the ramalama-run.yaml configuration and upgrades the core SDKs (ramalama, llama-stack, and its client) to their latest minor releases in the project manifests.

File-Level Changes

Change Details Files
Standardize environment variable default syntax in runtime configuration
  • Replaced ${env.VAR:default} with ${env.VAR:=default} for the provider URL
  • Applied the same := default syntax to all SQLite DB path entries
  • Migrated telemetry settings (service_name, sinks, sqlite_db_path) to use :=
  • Adjusted default API key assignments for external search and LLM providers
src/ramalama_stack/ramalama-run.yaml
Upgrade core dependencies to new minor versions
  • Bumped ramalama from 0.9.3 to 0.10.0
  • Bumped llama-stack and llama-stack-client to 0.2.13
  • Added asyncpg (0.30.0) to support the updated llama-stack
requirements.txt
pyproject.toml
uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@nathan-weinberg nathan-weinberg changed the title deps: bump ramalama to 0.9.3 and llama-stack to 0.2.11 deps: bump ramalama to 0.10.0 and llama-stack to 0.2.13 Jun 30, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nathan-weinberg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading key project dependencies, ramalama and llama-stack, to their latest stable versions. This update cascades through the project's dependency management files, introducing new transitive dependencies like asyncpg and refining existing dependency relationships. Additionally, a minor but important change was made to how environment variables are handled in a configuration file, aligning with a more robust default assignment syntax.

Highlights

  • Dependency Updates: The core dependencies ramalama and llama-stack have been updated to their latest versions, 0.10.0 and 0.2.13 respectively. This includes updating pyproject.toml, requirements.txt, and uv.lock to reflect these new versions and their transitive dependencies.
  • New Dependency Introduction: The asyncpg package (version 0.30.0) has been introduced as a new dependency, likely due to changes in the updated llama-stack library.
  • Configuration File Adjustments: The ramalama-run.yaml configuration file has been updated to use the := operator for environment variable defaults (e.g., ${VAR:=default} instead of ${VAR:default}). This ensures that the default value is assigned to the variable if it is unset, rather than just used if unset or null.
  • Dependency Graph Refinements: The requirements.txt and uv.lock files show adjustments to the dependency relationships and via comments for several packages, reflecting how the updated llama-stack and ramalama versions now pull in or no longer require certain sub-dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nathan-weinberg - I've reviewed your changes - here's some feedback:

  • The PR title and description still reference ramalama 0.9.3 and llama-stack 0.2.11, but the changes bump to ramalama 0.10.0 and llama-stack 0.2.13—please update the metadata to match.
  • Verify that the use of ‘:=’ in your ${env.VAR:=default} interpolations is supported by the config loader, as it may not be equivalent to the usual default operator.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and description still reference ramalama 0.9.3 and llama-stack 0.2.11, but the changes bump to ramalama 0.10.0 and llama-stack 0.2.13—please update the metadata to match.
- Verify that the use of ‘:=’ in your `${env.VAR:=default}` interpolations is supported by the config loader, as it may not be equivalent to the usual default operator.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully updates the ramalama and llama-stack dependencies to their latest versions. Additionally, it standardizes the environment variable default assignment syntax in ramalama-run.yaml to use :=, which improves consistency and clarity in the configuration. These changes contribute positively to the project's maintainability and ensure the use of up-to-date libraries.

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg force-pushed the bumpelstiltskin branch 5 times, most recently from 7531101 to 3d3e5d4 Compare June 30, 2025 17:09
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg added the hold Do not merge until this label is removed label Jun 30, 2025
@nathan-weinberg nathan-weinberg force-pushed the bumpelstiltskin branch 2 times, most recently from fdd079c to 9431cc6 Compare June 30, 2025 22:10
@nathan-weinberg nathan-weinberg removed the hold Do not merge until this label is removed label Jun 30, 2025
@nathan-weinberg nathan-weinberg requested a review from a team June 30, 2025 22:14
@nathan-weinberg
Copy link
Collaborator Author

Test change was due to llamastack/llama-stack-client-python#240

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jul 1, 2025

LGTM

@nathan-weinberg nathan-weinberg merged commit 61ebafc into containers:main Jul 1, 2025
7 checks passed
@nathan-weinberg nathan-weinberg deleted the bumpelstiltskin branch July 1, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update environmental variable substitution for Llama Stack 0.2.13

2 participants