-
Notifications
You must be signed in to change notification settings - Fork 14
deps: bump ramalama to 0.10.0 and llama-stack to 0.2.13 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump ramalama to 0.10.0 and llama-stack to 0.2.13 #104
Conversation
Reviewer's GuideThis PR standardizes environment variable default syntax across the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nathan-weinberg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on upgrading key project dependencies, ramalama and llama-stack, to their latest stable versions. This update cascades through the project's dependency management files, introducing new transitive dependencies like asyncpg and refining existing dependency relationships. Additionally, a minor but important change was made to how environment variables are handled in a configuration file, aligning with a more robust default assignment syntax.
Highlights
- Dependency Updates: The core dependencies
ramalamaandllama-stackhave been updated to their latest versions,0.10.0and0.2.13respectively. This includes updatingpyproject.toml,requirements.txt, anduv.lockto reflect these new versions and their transitive dependencies. - New Dependency Introduction: The
asyncpgpackage (version0.30.0) has been introduced as a new dependency, likely due to changes in the updatedllama-stacklibrary. - Configuration File Adjustments: The
ramalama-run.yamlconfiguration file has been updated to use the:=operator for environment variable defaults (e.g.,${VAR:=default}instead of${VAR:default}). This ensures that the default value is assigned to the variable if it is unset, rather than just used if unset or null. - Dependency Graph Refinements: The
requirements.txtanduv.lockfiles show adjustments to the dependency relationships andviacomments for several packages, reflecting how the updatedllama-stackandramalamaversions now pull in or no longer require certain sub-dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nathan-weinberg - I've reviewed your changes - here's some feedback:
- The PR title and description still reference ramalama 0.9.3 and llama-stack 0.2.11, but the changes bump to ramalama 0.10.0 and llama-stack 0.2.13—please update the metadata to match.
- Verify that the use of ‘:=’ in your
${env.VAR:=default}interpolations is supported by the config loader, as it may not be equivalent to the usual default operator.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and description still reference ramalama 0.9.3 and llama-stack 0.2.11, but the changes bump to ramalama 0.10.0 and llama-stack 0.2.13—please update the metadata to match.
- Verify that the use of ‘:=’ in your `${env.VAR:=default}` interpolations is supported by the config loader, as it may not be equivalent to the usual default operator.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully updates the ramalama and llama-stack dependencies to their latest versions. Additionally, it standardizes the environment variable default assignment syntax in ramalama-run.yaml to use :=, which improves consistency and clarity in the configuration. These changes contribute positively to the project's maintainability and ensure the use of up-to-date libraries.
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
7531101 to
3d3e5d4
Compare
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
3d3e5d4 to
64afa73
Compare
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
fdd079c to
9431cc6
Compare
|
Test change was due to llamastack/llama-stack-client-python#240 |
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
9431cc6 to
ad17b98
Compare
|
LGTM |
Summary by Sourcery
Bump dependency versions for ramalama and llama-stack and standardize environment variable default syntax in the ramalama-run configuration
Enhancements: