Skip to content

Conversation

@Pallavi-Janardhan
Copy link
Contributor

@Pallavi-Janardhan Pallavi-Janardhan commented Dec 29, 2025

DOC-13422

Created and added a new document for Eventing Memory Quota and linked it from the Sizing Guidelines document. Also modified the existing Sizing Guidelines doc.

Docs preview for Sizing Guidelines

and

Docs preview for Eventing Memory Quota

Preview credentials

NOTE For Writer: DO NOT Forget that this PR must be merged with the PR --> (couchbaselabs/docs-devex#555)

Copy link
Contributor

@sarahlwelton sarahlwelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pallavi-Janardhan , can you please confirm that you're making the changes you want to be making in this PR? I can do a more thorough review once you're sure you're committing the right changes.

Thanks!

Copy link
Contributor Author

@Pallavi-Janardhan Pallavi-Janardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have placed the newly created "eventing-memory-quota.adoc" doc under the "modules/learn/pages/buckets-memory-and-storage" directory and updated the cross-ref from sizing guidelines doc to this. Also have updated the nav.adoc (navigation doc).

Kindly review and let me know your comments or approve.

@Pallavi-Janardhan
Copy link
Contributor Author

@sarahlwelton and @simon-dew can you please have a look at this and let me know if it is ok? If yes, kindly approve so that I can merge it.

Thanks

Copy link
Contributor

@sarahlwelton sarahlwelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a lot of work. Did you go through writing a doc plan for this work? I'm not sure that you're on the right track with how you chose to approach this, and we might have been able to guide you with a doc plan ahead of time.


CPU::
CPU refers to the number of cores and clock speed that are required to run your workload.
CPU specifies the number of cores and clock speed required to run your workload.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CPU specifies the number of cores and clock speed required to run your workload.
CPU controls the number of cores and the clock speed required to run your workload.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just realized you left a 👍 on this but didn't actually make the changes? Can you confirm why?

Copy link
Contributor

@sarahlwelton sarahlwelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a lot of work. Did you go through writing a doc plan for this work? I'm not sure that you're on the right track with how you chose to approach this, and we might have been able to guide you with a doc plan ahead of time.

@abhijpes
Copy link

abhijpes commented Jan 8, 2026

Hi @Pallavi-Janardhan Following up on the prior discussion, after further review I believe the following location is appropriate for a dedicated Eventing Memory Quota documentation page:

Screenshot 2026-01-08 at 2 04 16 PM

Copy link
Contributor

@simon-dew simon-dew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @Pallavi-Janardhan today, my comments are:

  1. Remove eventing-memory-quota.adoc from this PR and revert the changes to the navigation. In the Sizing Guidelines document, keep a link to xref:eventing:eventing-memory-quota.adoc (see below) and any style changes, following Sarah's comments.
  2. Create a new PR in the docs-devex repo to add eventing-memory-quota.adoc to the eventing module, as suggested by @abhijpes.

Pallavi-Janardhan and others added 16 commits January 13, 2026 00:35
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
…-quota.adoc

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
This will also build the related docs-devex branch
@Pallavi-Janardhan
Copy link
Contributor Author

As discussed with Abhishek Jindal, I have added a section --> "Memory Management in Containerized vs Non-Containerized Environments", in the Eventing Memory Quota file.

As discussed with my doc architects, am creating another PR just for the Eventing file that is going into another repo - docs-devex repo.

The PR for that is --> couchbaselabs/docs-devex#555

Please do review both the PRs and let me know your comments/approval.

Thanks and regards,
Pallavi

Copy link
Contributor

@sarahlwelton sarahlwelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some issues. Thanks.

Pallavi-Janardhan and others added 5 commits January 13, 2026 22:44
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
Making few editorial review comments

Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
@Pallavi-Janardhan Pallavi-Janardhan removed the request for review from RichardSmedley January 14, 2026 15:01
@Pallavi-Janardhan
Copy link
Contributor Author

Have made all the suggested modifications. Please review and approve.

Copy link
Contributor

@sarahlwelton sarahlwelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment.


CPU::
CPU refers to the number of cores and clock speed that are required to run your workload.
CPU specifies the number of cores and clock speed required to run your workload.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just realized you left a 👍 on this but didn't actually make the changes? Can you confirm why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants