Fix #124: Manage entropy bits in TimeBasedEpochGenerator #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Feel free to change this to match your style or reject it. :) |
Owner
|
Ok thanks! Looks like I need to read this with some thought, due to changes. Happy New Year & thank you again! |
cowtowncoder
approved these changes
Dec 5, 2025
Owner
cowtowncoder
left a comment
cowtowncoder
left a comment
There was a problem hiding this comment.
Looks great, (finally) approved!
Owner
|
@chadparry Sorry it took so long: code was fine as-is and I should have come back much earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation guards against overflow by ensuring that the seeded counter starts off with the most significant bit cleared. It also doesn't use
UUIDUtil.constructUUID, which discards some of the entropy bits, leading to duplicated UUIDs.