Skip to content

[ub] cleanups and feedback from initial reviewers#8739

Draft
notadragon wants to merge 9 commits intocplusplus:ub-ifndrfrom
notadragon:ub-ifndr-cwgreview1
Draft

[ub] cleanups and feedback from initial reviewers#8739
notadragon wants to merge 9 commits intocplusplus:ub-ifndrfrom
notadragon:ub-ifndr-cwgreview1

Conversation

@notadragon
Copy link
Contributor

No description provided.

@notadragon
Copy link
Contributor Author

No need to merge this while work is in progress, but we can point people at this PR to review changes that have happened without re-reading the entire annex.

@jensmaurer jensmaurer marked this pull request as draft February 12, 2026 21:05
@jensmaurer
Copy link
Member

Converting this pull request to a draft. @notadragon , let me know when this is ready.

Copy link

@shafik shafik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of the comments I made


\pnum
\begin{example}
\begin{codeblock}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define A
#define B defined(A)
#if B // Ill-formed no diagnostic required, defined is generated by macro replacement for controlling expression
#endif


\pnum
\begin{example}
\begin{codeblock}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "  // Ill-formed no diagnoatic required, does not match one of the two allowable forms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments