Using a util class to avoid code duplication code smell

Author: Anton Krug

com.googlecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/Checker.java

@@ -17,6 +17,7 @@
 
 import com.googlecode.cppcheclipse.core.command.CppcheckCommand;
 import com.googlecode.cppcheclipse.core.command.ProcessExecutionException;
+import com.googlecode.cppcheclipse.core.utils.PathMacroReplacer;
 
 /**
  * This class should abstract from the eclipse concepts for easier testability.
@@ -73,9 +74,8 @@ public Checker(IConsole console, IPreferenceStore projectPreferences,
 			symbols = new Symbols();
 		}
 
-		String binaryPath = CppcheclipsePlugin.getConfigurationPreferenceStore()
-		.getString(IPreferenceConstants.P_BINARY_PATH)
-		.replace("${eclipse_home}", System.getProperty("eclipse.home.location").replace("file:/", ""));
+		String binaryPath = PathMacroReplacer.process(CppcheclipsePlugin.getConfigurationPreferenceStore()
+		.getString(IPreferenceConstants.P_BINARY_PATH));
 
 		command = new CppcheckCommand(console, binaryPath, settingsPreferences,
 				projectPreferences, toolchainSettings.getUserIncludes(), toolchainSettings.getSystemIncludes(), symbols);

com.googlecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/CppcheclipsePlugin.java

@@ -26,6 +26,7 @@
 
 import com.googlecode.cppcheclipse.core.command.ProcessExecutionException;
 import com.googlecode.cppcheclipse.core.utils.IHttpClientService;
+import com.googlecode.cppcheclipse.core.utils.PathMacroReplacer;
 
 /**
  * The activator class controls the plug-in life cycle
@@ -156,9 +157,8 @@ public boolean removeChangeListener(IPropertyChangeListener listener) {
 
 	private synchronized ProblemProfile getInternalNewProblemProfile(IConsole console, IPreferenceStore store) throws CloneNotSupportedException, XPathExpressionException, IOException, InterruptedException, ParserConfigurationException, SAXException, ProcessExecutionException {
 		if (profile == null) {
-			String binaryPath = CppcheclipsePlugin.getConfigurationPreferenceStore()
-			.getString(IPreferenceConstants.P_BINARY_PATH)
-			.replace("${eclipse_home}", System.getProperty("eclipse.home.location").replace("file:/", ""));
+			String binaryPath = PathMacroReplacer.process(CppcheclipsePlugin.getConfigurationPreferenceStore()
+			.getString(IPreferenceConstants.P_BINARY_PATH));
 			profile = new ProblemProfile(console, binaryPath);
 			registerChangeListener();
 			addChangeListener(profile);

com.googlecode.cppcheclipse.core/src/com/googlecode/cppcheclipse/core/utils/PathMacroReplacer.java

@@ -0,0 +1,11 @@
+package com.googlecode.cppcheclipse.core.utils;
+
+public class PathMacroReplacer {
+	
+	// TODO implement the VariablesPlugin
+	
+	public static String process(String input) {
+		return input.replace("${eclipse_home}", System.getProperty("eclipse.home.location").replace("file:/", ""));
+	}
+
+}

com.googlecode.cppcheclipse.ui/src/com/googlecode/cppcheclipse/ui/UpdateCheck.java

@@ -22,6 +22,7 @@
 import com.googlecode.cppcheclipse.core.IPreferenceConstants;
 import com.googlecode.cppcheclipse.core.command.UpdateCheckCommand;
 import com.googlecode.cppcheclipse.core.command.Version;
+import com.googlecode.cppcheclipse.core.utils.PathMacroReplacer;
 
 public class UpdateCheck {
 	private static final String DATE_PATTERN = "yyyy.MM.dd HH:mm:ss"; //$NON-NLS-1$
@@ -93,9 +94,8 @@ private static boolean needUpdateCheck() {
 	public static boolean startUpdateCheck() {
 		// do not start another update check, if one is already running
 		if (UpdateCheck.needUpdateCheck()) {
-			String binaryPath = CppcheclipsePlugin.getConfigurationPreferenceStore()
-			.getString(IPreferenceConstants.P_BINARY_PATH)
-			.replace("${eclipse_home}", System.getProperty("eclipse.home.location").replace("file:/", ""));
+			String binaryPath = PathMacroReplacer.process(CppcheclipsePlugin.getConfigurationPreferenceStore()
+			.getString(IPreferenceConstants.P_BINARY_PATH));
 			new UpdateCheck(true).check(binaryPath);
 			return true;
 		}

com.googlecode.cppcheclipse.ui/src/com/googlecode/cppcheclipse/ui/preferences/BinaryPathPreferencePage.java

@@ -37,6 +37,7 @@
 import com.googlecode.cppcheclipse.core.IPreferenceConstants;
 import com.googlecode.cppcheclipse.core.command.Version;
 import com.googlecode.cppcheclipse.core.command.VersionCommand;
+import com.googlecode.cppcheclipse.core.utils.PathMacroReplacer;
 import com.googlecode.cppcheclipse.ui.Console;
 import com.googlecode.cppcheclipse.ui.Messages;
 import com.googlecode.cppcheclipse.ui.UpdateCheck;
@@ -116,9 +117,7 @@ protected boolean checkState() {
 				if (super.checkState()) {
 					// check if it is valid cppcheck binary
 					try {
-						String path = getTextControl().getText()
-						        .replace("${eclipse_home}", System.getProperty("eclipse.home.location").replace("file:/", ""));
-						        
+						String path = PathMacroReplacer.process(getTextControl().getText());					        
 						VersionCommand versionCommand = new VersionCommand(
 								Console.getInstance(), path);
 						Version version = versionCommand