Skip to content

Conversation

@Sudrut
Copy link
Contributor

@Sudrut Sudrut commented Dec 16, 2025

migrate multiple pages from cppref, with no Missing component:

  • cpp/language/functions
  • cpp/language/function
  • cpp/language/default_arguments
  • cpp/language/variadic_arguments

@vercel
Copy link

vercel bot commented Dec 16, 2025

@Sudrut is attempting to deploy a commit to the microcber's projects Team on Vercel.

A member of the Team first needs to authorize it.

Lancern
Lancern previously approved these changes Dec 16, 2025
Copy link
Collaborator

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a nit

Comment on lines 5 to 6
cppdoc:
keys: ["cpp.lang.functions.default_arguments"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now no longer need these keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just to make DocLinks to work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now no longer need these keys.

Maybe the map maintained in doc-index.ts could be replaced by a set of absolute paths? I'm not sure if it's suitable to change that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just to make DocLinks to work

We had a discussion before and the final conclusion is to abandon the keys. All future DocLink should be used with paths rather than keys. Existing DocLink could continue to exist, and it's going to be replaced in future patches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it just to make DocLinks to work

We had a discussion before and the final conclusion is to abandon the keys. All future DocLink should be used with paths rather than keys. Existing DocLink could continue to exist, and it's going to be replaced in future patches.

The keys are removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants