-
Notifications
You must be signed in to change notification settings - Fork 11
feat: migrate functions documentation #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Sudrut is attempting to deploy a commit to the microcber's projects Team on Vercel. A member of the Team first needs to authorize it. |
Lancern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for a nit
| cppdoc: | ||
| keys: ["cpp.lang.functions.default_arguments"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now no longer need these keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it just to make DocLinks to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now no longer need these keys.
Maybe the map maintained in doc-index.ts could be replaced by a set of absolute paths? I'm not sure if it's suitable to change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it just to make DocLinks to work
We had a discussion before and the final conclusion is to abandon the keys. All future DocLink should be used with paths rather than keys. Existing DocLink could continue to exist, and it's going to be replaced in future patches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it just to make DocLinks to work
We had a discussion before and the final conclusion is to abandon the keys. All future
DocLinkshould be used with paths rather than keys. ExistingDocLinkcould continue to exist, and it's going to be replaced in future patches.
The keys are removed now.
migrate multiple pages from cppref, with no
Missingcomponent: