chore: now DocLink works without keys #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sudrut is attempting to deploy a commit to the microcber's projects Team on Vercel. A member of the Team first needs to authorize it. |
Lancern
reviewed
Dec 16, 2025
src/components/DocLink.astro
Outdated
| import { isLinkMissing, normalizeLink } from "../lib/doc-link"; | ||
| interface Props { | ||
| src: string; |
Collaborator
There was a problem hiding this comment.
Can we rename this property to something like dest?
Contributor
Author
There was a problem hiding this comment.
Can we rename this property to something like
dest?
OK! All existing mdx doc files need to change the property used in DocLink too.
Contributor
Author
There was a problem hiding this comment.
Build will fail until all <DocLink src=...> is substituted by <DocLink dest=...>
Contributor
Author
There was a problem hiding this comment.
Build will fail until all
<DocLink src=...>is substituted by<DocLink dest=...>
All occurrences are replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified
DocLink's logic, and useDocLinkindevelopment/migration/guideline. Also changedtrailingSlashtoalways.